Skip to content

DPL: revamp / remove Endian.h#15292

Merged
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:pr15292
Apr 22, 2026
Merged

DPL: revamp / remove Endian.h#15292
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:pr15292

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented Apr 19, 2026

C++20 (and even more so 23) has understanding of endianess.
No need to have a special wrapper include anymore.

@ktf ktf requested a review from a team as a code owner April 19, 2026 17:49
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 19, 2026

Error while checking build/O2/fullCI_slc9 for cb6ee22 at 2026-04-20 00:36:

++ cp /sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local11/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0
++ [[ -e /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/CMakeLists.txt ]]

Full log here.

@ktf
DPL: revamp / remove Endian.h
f9a689d 
C++20 (and even more so 23) has understanding of endianess.
No need to have a special wrapper include anymore.
@ktf
Copy link
Copy Markdown
Member Author

ktf commented Apr 22, 2026

Works on hyperloop. aarch64 issue understood to be unrelated. Merging.

@ktf ktf merged commit 5f89a2e into AliceO2Group:dev Apr 22, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ktf @alibuild